llvm / llvm/circt

[comb] Break out some canonicalizations into optimization pass

Open
#6,931 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Comb
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

We are probably abusing canonicalizations to implement optimizations which should really be in some sort of `optimize-comb` pass. Canonizations should really just be simple transformations which aid analysis. So we should create a pass, identify which canonicalizations should be moved and move them.

I think @darthscsi agrees with me. Dunno who else does.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing canonicalizations and the surrounding pass structure in CIRCT. Identify which transformations are optimizations rather than analysis-aiding canonicalizations, then create the optimize-comb pass and move the selected transformations; done means the pass exists and those responsibilities are separated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.