[FIRRTL] LowerMemory change in #6719 leads to ambiguous targets in EmitOMIR
Open
Nobody has claimed this yet.
FIRRTL
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
In bea85107e8e42261e9c2e3ed24dd398e7f33b915 we had to revert #6719. This change caused some memories that were previously targeted from OMIR to fail in the EmitOMIR pass. Opening this issue for tracking the effort to re-land the change, and will attempt to reduce the problem with a FIRRTL example here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the reverted #6719 change and compare the LowerMemory and EmitOMIR passes to understand how memories become ambiguous targets. Reproduce the failure with the FIRRTL example described in the issue, then verify that the underlying change can be re-landed without EmitOMIR target ambiguity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100