llvm / llvm/circt

[FIRRTL] Add folders for IntegerAddOp

Open
#6,696 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

FIRRTL good first issue
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

This is a primitive Property operation, defined by FIRRTL spec section 25.1.1. General folds for signed arbitrary precision integer arithmetic can be applied, but none were defined in the initial PR. This could include things like:

  • integer_add(a, 0) -> a
  • integer_add(constantA, constantB) -> constantA + constantB
  • etc...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with FIRRTL specification section 25.1.1 and the existing IntegerAddOp implementation from the initial PR. Identify how primitive property operations currently fold, then cover the listed zero-identity and constant-constant cases. Done means the requested arithmetic folds are implemented and their results are validated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.