llvm / llvm/circt

Will the `AttributeAnnotation` support setting the target to port?

Open
#6,581 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement FIRRTL
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

I noticed that “A reference target must be a wire, node, reg, or module” in docs. And in the code it says "Currently ports are not supported". https://github.com/llvm/circt/blob/7c59a2ef4324576db7d2b8ff6d24823f7562776f/lib/Dialect/FIRRTL/Transforms/LowerAnnotations.cpp#L323-L325
Is there any plan to support ports?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FIRRTL annotations documentation and lib/Dialect/FIRRTL/Transforms/LowerAnnotations.cpp around lines 323–325. Trace how AttributeAnnotation reference targets are handled and determine the requirements for port targets. Done means port targets are supported consistently and the documentation no longer says they are unsupported.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.