[FIRRTL] Dedupe should be able to dedupe classes
Open
enhancement
FIRRTL
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
The Dedupe pass currently skips over classes: https://github.com/llvm/circt/blob/2d822eabf696378ba14ce4b1a8a703af1e721589/lib/Dialect/FIRRTL/Transforms/Dedup.cpp#L1523-L1535
It should be possible to dedupe classes and object similarly to modules and instances.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in lib/Dialect/FIRRTL/Transforms/Dedup.cpp at the referenced lines and inspect how the Dedupe pass handles modules and instances versus classes. Determine the corresponding class and object cases, then verify that classes and objects are deduplicated similarly without changing the existing module and instance behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100