[CI] Don't run clang-tidy on non-gcc, maybe only use same clang-tidy as clang used
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
Otherwise the flags used for clang-tidy are those chosen for GCC, such as this:
```
error: unknown argument: '-fno-lifetime-dse' [clang-diagnostic-error]
```
(Also, if clang-tidy fails, shouldn't the build fail?)
Thought this was fixed previously but can't find the change, so maybe it wasn't.
Related: #5239 .
Observed here: https://github.com/llvm/circt/actions/runs/5978579297/job/16220967455?pr=5956#step:13:20
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the GitHub Actions job shown in the linked run, at step 13:20, and compare the compiler and clang-tidy configuration used there. Check related issue #5239 for prior context. Done means non-GCC configurations no longer receive incompatible GCC flags and clang-tidy failure behavior is explicitly addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, github-actions
- Domain
- build-system, ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100