llvm / llvm/circt

[FIRRTL][ExportVerilog] Mult/Add Width Cast

Open
#5,698 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Except the signedness mentioned in https://github.com/llvm/circt/issues/4152, seems the bit cast also doesn't work. I tried both Version 1.48.0 and 1.44.0.

Here we use the example in https://github.com/llvm/circt/pull/2825:

```firrtl
circuit Foo:
module Foo:
input a: UInt<4>
input b: UInt<4>
output d: UInt<8>

node c = mul(a, b)
d <= c
```

Runing `firtool Foo.fir` got:
```verilog
// Generated by CIRCT firtool-1.48.0
module Foo(
input [3:0] a,
b,
output [7:0] d
);

assign d = {4'h0, a} * {4'h0, b};
endmodule

```

Runing `firtool --lowering-options=explicitBitcast Foo.fir` got:
```verilog
// Generated by CIRCT firtool-1.48.0
module Foo(
input [3:0] a,
b,
output [7:0] d
);

assign d = 8'({4'h0, a} * {4'h0, b});
endmodule
```

From [the document](https://circt.llvm.org/docs/VerilogGeneration/) and https://github.com/llvm/circt/pull/2825, what we want here might be:
```verilog
// default
assign d = a * b;
// with --lowering-options=explicitBitcast
assign d = 8'(a * b);
```

Please kindly suggest whether I missed any option that may help with this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the FIRRTL example with firtool 1.48.0 and the default and explicitBitcast lowering options. Compare the generated Verilog with the expected a * b and 8'(a * b) forms; done means determining whether an option is missing or the lowering output needs correction.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.