[ExportVerilog] Clean up FlatSymbolRefAttr emission
Open
Nobody has claimed this yet.
ExportVerilog
good first issue
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
By https://github.com/llvm/circt/pull/5180 `ExprEmitter::visitSV(XMRRefOp op)` and `emitTextWithSubstitutions` duplicate logic regarding FlatSymbolRefAttr emission so reuse the code there.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for ExprEmitter::visitSV(XMRRefOp op) and emitTextWithSubstitutions, then compare their FlatSymbolRefAttr emission paths. Confirm how the logic introduced by pull request 5180 is duplicated and identify the shared location expected by the surrounding ExportVerilog code. Done means the duplicate emission logic is reused without changing output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100