llvm / llvm/circt

[Handshake] `nested_diamonds.mlir` with `--dynamic-parallelism=locking` deadlocks

Open
#5,139 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Handshake HandshakeToHW
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

https://github.com/llvm/circt/blob/main/integration_test/Dialect/Handshake/nested_diamonds/nested_diamonds.mlir#L11-L13 currently deadlocks. Since cocotb/iverilog tests aren't enabled (yet) in CI, this isn't (yet) an error when check-circt-integration is run in CI.

CC @Dinistro

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with integration_test/Dialect/Handshake/nested_diamonds/nested_diamonds.mlir lines 11-13 and reproduce the test with --dynamic-parallelism=locking. Trace the deadlock in the Handshake dynamic-parallelism path, then verify the test completes and that check-circt-integration can detect the failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.