[Dedup] Vector of bundles, with different field names should dedup
Open
Nobody has claimed this yet.
FIRRTL
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
Bundles with different field names dedup, but they don't if the bundle is an element of a vector.
The Simple0 and Simple1 should dedup.
firrtl.circuit "Simple" {
firrtl.module @Simple0() {
%a = firrtl.wire: !firrtl.vector<bundle<a: uint<1>>, 2>
}
firrtl.module @Simple1() {
%b = firrtl.wire: !firrtl.vector<bundle<b: uint<1>>, 2>
}
firrtl.module @Simple() {
firrtl.instance simple0 @Simple0()
firrtl.instance simple1 @Simple1()
}
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the FIRRTL reproducer in the issue and trace the deduplication path for vector-of-bundle types. Confirm the behavior using the Simple0 and Simple1 modules; done means those modules deduplicate despite their differing bundle field names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100