Build doesn't fail if clang-tidy throws warnings
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
https://github.com/llvm/circt/actions/runs/4259442120/jobs/7411671989
^^ Clang-tidy generated warnings yet this passed.
Clearly wrong.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked GitHub Actions run and inspect the CIRCT build and clang-tidy workflow configuration. Determine why clang-tidy warnings do not affect the job result; done means the workflow fails when clang-tidy emits warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, github-actions
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100