llvm / llvm/circt

[ESI][Services] Change ServiceInstanceOp's 'impl_type' (back) to a general attribute

Open
#3,942 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ESI
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Said attribute should either be a string OR an attribute which implements an AttrInterface which lists the required ports. Another possible design point is to have a set of ops much like the std service decls which can be used to request a particular implementation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating ServiceInstanceOp and its impl_type attribute in the ESI Services implementation. Read the surrounding service declarations and the AttrInterface requirements, then compare the proposed general-attribute design with the alternative set of operations. Done means an agreed design is implemented and its behavior is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.