[FIRRTL] Use EnumAttr for `sym_visibility` of `InnerSymPropertiesAttr`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
Currently `sym_visibility` uses `StringAttr` as a container but `sym_visibility` is either `public` or `private`. Therefore, it would be cleaner to use enum attr to represent visibility.
https://github.com/llvm/circt/blob/04797976d2ccdb6e3d1f8ecdc9dee60cc3d5a8c5/include/circt/Dialect/FIRRTL/FIRRTLAttributes.td#L203-L208
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with include/circt/Dialect/FIRRTL/FIRRTLAttributes.td at the linked InnerSymPropertiesAttr definition. Read the surrounding attribute declarations and search for sym_visibility uses to identify affected parsing, printing, verification, and tests. Done means visibility is represented consistently as the requested enum attribute without breaking existing FIRRTL behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100