llvm / llvm/circt

[MSFT] [Module] Use `modifyPorts` instead of previous `removePorts` and `addPorts`

Open
#3,543 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

msft
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

`HWModule` has a `modifyPorts` method which we just added to `MSFTModule`. (It actually uses `hw::modifyPorts` since the ops are compatible in that regard.) Make all the old code use that method (or one of the two convenience ones in `HWMutableModuleLike`) instead of the old ones.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the CIRCT codebase for uses of the old removePorts and addPorts operations, then read HWModule, MSFTModule, and HWMutableModuleLike to understand the available replacements. Update all applicable call sites to use modifyPorts or its convenience methods, and verify that no old uses remain and the relevant tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.