llvm / llvm/circt

Cannot append System Verilog output tests to sv-dialect.mlir

Open
#3,341 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

This is obviously not a huge deal, but there is a slight inconvenience in that it appears to be impossible to add new System Verilog tests at the end of the file. It looks like this is because the last tests in the file are checking labels in the MLIR output, which is emitted after all the System Verilog: https://github.com/llvm/circt/blob/a89324428efef0120337f7b0e7de1164f5775693/test/Conversion/ExportVerilog/sv-dialect.mlir#L1465-L1473

The rest of this file is checking System Verilog output, but the above makes adding new System Verilog checks at the end of the file impossible. @prithayan it looks like you added the above tests in https://github.com/llvm/circt/commit/333089b9b39137b98061b43a01d77496991633f9, is there any specific reason for them to be in that file, or could we move the MLIR checks elsewhere?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with test/Conversion/ExportVerilog/sv-dialect.mlir, especially lines 1465-1473, and inspect the MLIR label checks that follow the SystemVerilog output checks. Move those MLIR checks to an appropriate separate location or file so new SystemVerilog checks can be appended, while preserving the existing test coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.