[FIRRTL] Canonicalize integer interval tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
Tests checking whether integers belong to a range often appear in the form of or'd equality checks.
In #2748, canonicalization was attempted on the `comb` dialect, however the transformation was incorrect due to the semantics of x values and the feature was removed by #2943. Since the transformation is legal on FIRRTL, it should be re-implemented in a FIRRTL canonicalizer.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the earlier comb-dialect attempt in #2748 and its removal in #2943, then locate the FIRRTL canonicalizer and integer interval tests. Re-implement the transformation where FIRRTL x-value semantics make it legal, and confirm that the relevant tests cover the canonicalized range checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100