[FIRRTL] Remove FConnecLike interface
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
https://github.com/llvm/circt/commit/c4917d7f7f34df9b2561b1239e718fb7ce06d184 introduced FConnectLike interface to abstract ConnectOp and StrictConnectOp. Even though almost all ConnectOp is converted into StrictConnectOp especially in the later pipeline, ConnectOp still exists early in the pipeline (especially before the first canonicalization). Once we can ensure that connect ops are eliminated completely, it would be better to replace FConnecLike with StrictConnectOp and remove FconnectLike from the codebase.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit c4917d7f7f34df9b2561b1239e718fb7ce06d184 and locating FConnectLike, ConnectOp, and StrictConnectOp usages in the codebase. Trace the pipeline before the first canonicalization to verify that ConnectOp can be eliminated completely; the work is done when FConnectLike can be removed and the project still builds and tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100