[FIRParser] Should produce an error when an expression is not inside a module
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
When the last line is not indented far enough, it is silently discarded. The parser should produce an error.
```scala
circuit Foo:
module Foo :
output io : UInt<1>
io is invalid
```
`firtool --parse-only test.fir` gives:
```mlir
firrtl.module @Foo(out %io: !firrtl.uint<1>) {
}
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue is in the FIRParser path exercised by firtool; start by running `firtool --parse-only test.fir` with the shown input and tracing where the out-of-module line is handled. Done means the parser reports an error instead of silently omitting `io is invalid`, with the invalid input no longer being accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100