[FIRRTL] Use Namespace to legalize symbol names
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 524
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 46
Description
Ensure new symbol names are legalized using `Namespace` in `LowerTypes`,
For example, this code currently does not legalize names,
```
if (hasDontTouch)
sym = StringAttr::get(builder->getContext(),
"sym" + op.nameAttr().getValue());
auto newInstance = builder->create(
resultTypes, op.moduleNameAttr(), op.nameAttr(),
direction::packAttribute(context, newDirs),
builder->getArrayAttr(newNames), op.annotations(),
builder->getArrayAttr(newPortAnno), op.lowerToBindAttr(), sym);
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating LowerTypes and the existing Namespace implementation. Trace the symbol-name construction shown in the issue and determine how legalization should be applied; done means newly generated symbol names are legalized consistently without changing unrelated names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100