llvm / llvm/circt

Rename CreateSiFiveMetadata -> LowerSiFiveMetadata

Open
#2,098 0 comments 0 reactions 0 assignees View on GitHub
FIRRTL
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

We currently have `createCreateSiFiveMetadataPass` but we don't use the word "Create" for much of anything in the MLIR ecosystem. How about "Lower" or "Emit" since this is performing a lowering?

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate createCreateSiFiveMetadataPass and the CreateSiFiveMetadata name across the CIRCT codebase, then inspect their declarations, definitions, and call sites. Rename them consistently to the chosen LowerSiFiveMetadata form and verify that the project builds and relevant tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.