llvm / llvm/circt

[PyCDE] Investigate using pybind11 without the C API

Open
#1,641 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

PyCDE
Dominant language
C++
Stars
2.2k
Forks
524
Avg merge
3d 2h
Merged PRs (30d)
46

Description

Going through a C API is a PITA so I'm more likely to add features in Python than CIRCT. That's unfortunate since at least several things are re-useable and really should be in CIRCT's C++ code. As of now, PyCDE has this awkward one-foot-in-each-world situation.

@stellaraccident: now that we have universal builds, do you think we'll run into linking issues? If so, would it be easy(-ish) to cram all the problematic code into the PyBind11 extension SO to really avoid them? That would work for the PyCDE use case.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing PyCDE's current C API boundary and its pybind11 extension, then investigate whether universal builds create linking issues. Compare keeping reusable functionality in CIRCT's C++ code with placing problematic code in the PyBind11 extension; done requires a documented, agreed approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.