linux-credentials / linux-credentials/credentialsd
Filter devices that cannot fulfill the request
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 259
- Forks
- 19
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 12
Description
For authenticators that cannot fulfill the request (e.g. no matching algorithms, resident key required but not supported), we should filter them from the device list.
(I'm not sure how to communicate to the user that this has been filtered; they might get confused that their device is plugged in but isn't showing up. Maybe we really need to send two lists: available devices and unavailable devices with a reason why they're not applicable.)
_Originally posted by @msirringhaus in https://github.com/linux-credentials/credentialsd/pull/149#pullrequestreview-4152833255_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating the code that builds the device list and checks authenticator capabilities, then trace how devices with unsupported algorithms or resident-key requirements are represented. Done means inapplicable devices are handled consistently and the issue of communicating filtered devices or their reasons has a decided behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux, rust
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100