Stricter types for select macro
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.9k
- Forks
- 457
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 16
Description
### Problem Description
Select macro doesn't validate choices other than `other` currently.
### Proposed Solution
Make the macro generic over value, and the choice keys required if the value is a union type.
Potential solution:
```tsx
declare function select(
value: T,
options: {
[key in T]: string
} & {
other: string
}
): string
```
### Alternatives Considered
I can extend the types or patch the dependency locally, but it could make sense to contribute this change to benefit everyone
### Additional Context
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the select macro type definitions and existing type tests, then verify that union-valued selections require every choice key while still accepting `other`; done means the TypeScript checks cover the stricter behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- internationalization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100