lingui / lingui/js-lingui

Stricter types for select macro

Open
#2,214 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.9k
Forks
457
Avg merge
1d 23h
Merged PRs (30d)
16

Description

### Problem Description

Select macro doesn't validate choices other than `other` currently.

### Proposed Solution

Make the macro generic over value, and the choice keys required if the value is a union type.

Potential solution:
```tsx
declare function select(
value: T,
options: {
[key in T]: string
} & {
other: string
}
): string
```

### Alternatives Considered

I can extend the types or patch the dependency locally, but it could make sense to contribute this change to benefit everyone

### Additional Context

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the select macro type definitions and existing type tests, then verify that union-valued selections require every choice key while still accepting `other`; done means the TypeScript checks cover the stricter behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
internationalization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.