YamuxStream is tagged to Unreadable too early, since there may be data that hasn't been processed
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 492
- Forks
- 130
- PR merge metrics
- No merged PRs in 30d
Description
From testing of my program, after YamuxStream tagging stream being unreadable in onFINReceived at this line, there may still be remaining data to be processed in onLengthRead.
So I think tagging stream being unreadable in onFINReceived is too early.
I have no better idea for now, so I just comment this line to workaround this issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/muxer/yamux/yamux_stream.cpp at onFINReceived and the referenced line, then trace how remaining data reaches onLengthRead in src/protocol/kademlia/impl/session.cpp. Confirm the stream is not marked unreadable before pending data is processed; done means the FIN and unreadable state ordering no longer loses that data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100