libgit2 / libgit2/pygit2

create_commit does not update the reflog

Open
#727 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Description

Hi,

I have noticed that v0.26.0 of create_commit does not create an entry in the reflog for the initial commit of a branch.

/private/tmp
4> mkdir d

/private/tmp
5> cd d
/private/tmp/d

/private/tmp/d
6> import pygit2

/private/tmp/d
7> repo = pygit2.init_repository(".")

/private/tmp/d
8> repo.config["user.email"] = "foo@bar.com"

/private/tmp/d
9> foo = repo.create_blob("foo")

/private/tmp/d
10> builder = repo.TreeBuilder()

/private/tmp/d
11> builder.insert("foo", foo, pygit2.GIT_FILEMODE_BLOB)

/private/tmp/d
12> tree_id = builder.write()

/private/tmp/d
13> repo.create_commit("refs/test", repo.default_signature, repo.default_signature, "test", tre
13: e_id, [])
13> f610cdd139fab6f738dfaff52839a552a6b8bb9e

/private/tmp/d
14> git reflog refs/test
  File "<ipython-input-14-afa1bc8c3c03>", line 1
    git reflog refs/test
             ^
SyntaxError: invalid syntax


/private/tmp/d
15> !git reflog refs/test

/private/tmp/d
16> !git --no-pager reflog refs/test

/private/tmp/d
17> repo.references["refs/test"].log
17> <function Reference.log>

/private/tmp/d
18> repo.references["refs/test"].log()
18> <_pygit2.RefLogIter at 0x10db93bc0>

/private/tmp/d
19> list(repo.references["refs/test"].log())
19> []

However it works it is not an initial commit.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the example with repo.create_commit("refs/test", ...) and checking list(repo.references["refs/test"].log()). Read the create_commit and Reference.log entry points and compare initial-commit behavior with the reported working non-initial case. Done means an initial commit creates the expected reflog entry without regressing existing updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.