libgit2 / libgit2/pygit2

Support for sha256 object identifiers?

Open
#1,411 0 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Description

First, thank you for all the hard work you put in the bindings.

Second, now that the latest revisions of git, and as far as I can tell libgit2 as well, both support using sha256 for object identifiers, I am wondering how much work it would be to add this to pygit2? Is the hashing function well-encapsulated in a few places or is it a widespread assumption that sha1 is used?

If support for it did not require too much mastery over the internals of pygit2, I would be willing to take a look at it.

Cheers,

Erick

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are identified. Start by tracing how pygit2 represents object identifiers and how those bindings depend on libgit2's SHA-1 assumptions. Determine whether SHA-256 support is localized or widespread; done means pygit2 can support SHA-256 object identifiers consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.