Repository.amend_commit with encoding=None
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 408
- Avg merge
- 2d 57m
- Merged PRs (30d)
- 7
Description
Currently, it will raise TypeError: expected new array length or list/tuple/str, not _cffi_backend._CDataBase at encoding_cstr = ffi.new('char[]', to_bytes(encoding)) while libgit2 supports setting NULL and not setting encoding in the commit message
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the amend_commit entry point and the encoding_cstr assignment shown in the issue. Check how encoding=None is converted before the libgit2 commit call, then inspect any existing amend_commit tests. Done means amend_commit accepts None without the reported TypeError and preserves the supported no-encoding behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100