`Repository.__init__` (possibly others) missing `os.PathLike` typing
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 408
- Avg merge
- 2d 57m
- Merged PRs (30d)
- 7
Description
Support for PathLikes was added in https://github.com/libgit2/pygit2/pull/990. However, it doesn't appear the typing for some of the affected methods were updated. Repository.__init__ was the one I caught, but there may be more (which is why this isn't just a PR, I didn't want to make this one change and end up missing others).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pygit2/repository.py around lines 1523–1528 and review the typing for Repository.init. Compare the affected methods with the PathLike support added in pull request 990, then inspect related annotations for omissions. Done means all affected method signatures accept os.PathLike consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100