libgit2 / libgit2/libgit2sharp
An error thrown by a custom `RpcSmartSubtransport` is consumed and not propagated to the client code
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.5k
- Forks
- 925
- PR merge metrics
- No merged PRs in 30d
Description
If implementing a custom RpcSmartSubtransport that throws an exception during the read or write operation, the error message is ignored in the SmartSubtransportStream because it is not a NativeException.
Related PR with fix and repro test: https://github.com/libgit2/libgit2sharp/pull/2164
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SmartSubtransportStream and the custom RpcSmartSubtransport read/write path described in the issue. Review the related PR #2164 and its repro test; done means the custom exception's message reaches client code and the repro test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100