libgit2 / libgit2/libgit2sharp
libgit2sharp is agnostic of GitHub Personal Access Token related errors
还没有人认领这个 Issue。
- 主要语言
- C#
- 星标
- 3.5k
- 派生
- 925
- PR 合并指标
- 30 天内没有已合并 PR
描述
Introduction
It's been a while since github deprecated the use of password on CLIs and applications. Personal access token is the way to get authenticated on these apps. libgit2sharp is quiet on errors and warnings pertinent to PATs.
For example,
access tokens can be created with only repository access. Which is restricted to do modifications outside the repository i.e., workflows, wikis and projects. Hence, trying to modify a workflow file using this token should outcome an access exception.
However, libgit2sharp behaves as if nothing happened when that event does occur. Nothing is performed, push fails, however, there is no error/warning report from libgit2sharp.
Reproduction steps
Create a PAT with only repository access. Now try to push a commit that modifies a workflow file.
Expected behavior
Show throw an exception or report an error.
Actual behavior
Does not throw an exception, behaves as if push was successful. However, push actually failed.
to mimic the behavior of git, behavior of libgit2sharp should look like following,
I created an example commit that modified following github workflow file: D:\Code\MyBlog\.github\workflows\deploy.yml
git properly reports the error,
$ git push origin dev
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 16 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (9/9), 804 bytes | 268.00 KiB/s, done.
Total 9 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To https://github.com/matrix/blog.git
! [remote rejected] dev -> dev (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/deploy.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/matrix/blog.git'
Version of LibGit2Sharp (release number or SHA1)
Latest
Operating system(s) tested; .NET runtime tested
Win 10, net sdk: 6.0.101
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
使用没有 workflow scope 的 PAT,修改 .github/workflows/deploy.yml,重现向 repository 执行 push 的过程,并将结果与 issue 中显示的 Git 命令进行比较。在 libgit2sharp 源代码中跟踪 push 操作及其报告的错误;完成的标准是,被拒绝的 workflow push 会引发异常或报告 remote 错误,而不是看起来已经成功。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- csharp, git
- 领域
- authentication, tooling
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100