libgit2 / libgit2/libgit2sharp
Deleted tags show up in the list
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.5k
- Forks
- 925
- PR merge metrics
- No merged PRs in 30d
Description
Reproduction steps
- Add a new tag in github repository online (www.github.com).
- Run .Net core Controller.
- Added tag show up in the Api.
- Delete a tag in github repository online.
- Run controller and API.
- Deleted tag show up in API Controller.
-
_repository = new Repository("localfolderpath"); var network = _repository.Network.Remotes.First(); var refSpecs = new List<string>() { network.FetchRefSpecs.First().Specification }; var fetchOptions = new FetchOptions { TagFetchMode = TagFetchMode.All }; fetchOptions.CredentialsProvider = (_url, _user, _cred) => new DefaultCredentials(); fetchOptions.CredentialsProvider += (_url, _user, _cred) => _userNamePasswordCredentials; Commands.Pull(_repository, new Signature(Guid.NewGuid().ToString(), Guid.NewGuid().ToString(), DateTime.Now), new PullOptions() { FetchOptions = fetchOptions, MergeOptions = new MergeOptions() { MergeFileFavor = MergeFileFavor.Theirs, CommitOnSuccess = true } }); foreach (Remote remote in _repository.Network.Remotes) { Commands.Fetch(_repository, remote.Name, new string[0], fetchOptions, null); _repository.Network.Fetch(remote.Name, remote.FetchRefSpecs.Select(r => r.Specification), fetchOptions); }
Expected behavior
- Deleted tags shouldn't come up when using _repository.Tags
Actual behavior
- Deleted tags come up in _repository.Tags
Version of LibGit2Sharp (release number or SHA1)
Libgit2Sharp 0.26.2
Operating system(s) tested; .NET runtime tested
.Net Core 3.5, Microsoft Visual Studio Professional 2019 Version 16.9.0, .Net Framework 4.7.03190, Microsoft windows 10 pro.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with LibGit2Sharp 0.26.2 using the shown Pull and Fetch calls, then inspect how _repository.Tags is populated after a remote tag is deleted. Compare the fetched refs with the expected tag list; done means deleted remote tags no longer appear in _repository.Tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, git
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100