libgit2 / libgit2/libgit2sharp
NormalMerge should call callback on conflicts
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 3.5k
- Forks
- 925
- PR merge metrics
- No merged PRs in 30d
Description
Reproduction steps
[Fact]
public void NormalMergeShouldCallCallbackOnConflicts()
{
string committishToMerge = "fast_forward";
using (var repo = new Repository(SandboxMergeTestRepo()))
{
Touch(repo.Info.WorkingDirectory, "b.txt", "this is an alternate change");
var conflicts = 0;
var options = new MergeOptions
{
OnCheckoutNotify = (path, flags) =>
{
conflicts++;
return true;
},
CheckoutNotifyFlags = CheckoutNotifyFlags.Conflict,
FastForwardStrategy = FastForwardStrategy.NoFastForward,
};
Assert.Throws<CheckoutConflictException>(() => repo.Merge(committishToMerge, Constants.Signature, options));
Assert.Equal(1, conflicts) ;
}
}
Expected behavior
Test shouldn't fail
Actual behavior
Test fails
Version of LibGit2Sharp (release number or SHA1)
df3b22a754ef56da8d7e3c330ce2d783c2b7982e
Operating system(s) tested; .NET runtime tested
Windows netcore 2.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the NormalMergeShouldCallCallbackOnConflicts test and the repo.Merge call using MergeOptions.OnCheckoutNotify, CheckoutNotifyFlags.Conflict, and NoFastForward. Reproduce the failure, trace conflict handling, and confirm the callback runs once while CheckoutConflictException is still raised.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, git
- Domain
- backend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100