libgit2 / libgit2/libgit2sharp
'Too many redirects or authentication replays' on clone from TFS
還沒有人認領這個 Issue。
- 主要語言
- C#
- 星號
- 3.5k
- 分支
- 925
- PR 合併指標
- 30 天內沒有已合併 PR
描述
After updating to Team Foundation Server TFS 2018 & 2017 Update 3, we are not be able to login to GIT repository using LibGit2Sharp library using Access Token. Please check the code below:
`
string accessToken = "eyJ0eXAiOiJKV1QiLCJ...";
NetworkCredential gitCredentials = new NetworkCredential(string.Empty, accessToken);
string localRepoPath = string.Empty;
string gitTfsRepo = "http://mjtfs2017:8080/tfs/DefaultCollection/_git/GITTest001";
try
{
localRepoPath = Repository.Clone(gitTfsRepo, @"D:\temp\GIT",
new CloneOptions()
{
CredentialsProvider = GetCredentialsHandler(gitCredentials),
IsBare = false
});
}
catch (Exception err)
{
Console.WriteLine(err);
}
Console.WriteLine(localRepoPath);
`
I communicated with Microsoft TFS/VSTS Team they gave following response:
The fact that you received those responses from the code snip I provided means that your extension is correctly configured (regarding scopes at least) and TFS is correctly accepting the extension’s access token to perform git operations through HTTP, when the git client sends it.
Additionally, if I use the next command, using git for Windows, I’m able to fully interact with a TFS repo with that access token:
git -c http.extraheader="Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJ..." clone http://at1-tfs-test1-angallo.westus2.cloudapp.azure.com:8080/tfs/DefaultCollection/_git/test_project_1
But that same command doesn’t work for git for Linux, probably because my git client on my Linux machine doesn’t send or correctly consider these HTTP headers (just as LibGit2Sharp seems to not do too (from your latest Fiddler trace I still see the Authentication header missing)). So I still believe the problem here comes from the git client, not TFS or the access token.
Please suggest, thanks in advance.
LibGit2Sharp version: 0.26.0-preview-0027
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從所提供重現中的 Repository.Clone 呼叫及其 CredentialsProvider 開始,然後將該請求與傳送 Authorization Bearer 標頭的正常運作 git 命令進行比較。針對 TFS 重現 clone,並檢查是否傳送了該標頭;當經過 access token 驗證的 clone 在沒有 redirect 或 authentication replay 錯誤的情況下完成時,即表示完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- csharp, git
- 領域
- authentication, backend, networking
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100