libgit2 / libgit2/libgit2sharp

System.Net.Http.dll 2.4.0.0 NotFound

Open
#1,580 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
3.5k
Forks
925
PR merge metrics
No merged PRs in 30d

Description

Reproduction steps
  1. Create a new blank WebAPI project. Note under references the System.Net.Http reference version is 4.0.0.0
  2. install any version of LibGet2Sharp (any version after 0.24.1) and note that the new System.Net.Http dll is now version 4.2.0.0
  3. add a new ms test project, and attempt to write a test against anything that requires use of a RequestMessageResult. E.G: the following for example:
            [TestMethod]
            public async Task ResponseShouldRenderCorrectly()
            {
                var moq = new Mock<IGitHubRepository>();
                var target = new Target(moq.Object);
                var dto = new DTO
                {
                    SomeField = "Nate Was Here"
                };
                var actualResponse = target.StatusCode(System.Net.HttpStatusCode.OK, dto);

                Assert.IsNotNull(actualResponse);
                Assert.IsInstanceOfType(actualResponse, typeof(ResponseMessageResult));

                var strResponse = actualResponse as ResponseMessageResult;
                Assert.AreEqual(System.Net.HttpStatusCode.OK, strResponse.Response.StatusCode);
                var actual = await strResponse?.Response?.Content.ReadAsStringAsync();
                var expected = "{\"SomeField\":\"Nate Was Here\"}";
                Assert.AreEqual(expected, actual);

            }
Expected behavior

I should be able to run the test code above to work, and i should be able to debug into the Target class used in the test.

Actual behavior

I receive a FileNotFound when looking for the System.Net.Http.dll with version 4.2.0.0 which it looks for in the BuildExtensions. That file is not reachable in my class library with my test, which is referencing the webapi project i created.

Version of LibGit2Sharp (release number or SHA1)

Version 0.42.1 works, but 0.25.0 and 0.25.2 are both causing this type of un-testable code.

Operating system(s) tested; .NET runtime tested

Windows 10, .net 4.6.1 run time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure using the blank WebAPI project, LibGit2Sharp 0.25.x, and the added MSTest project described in the issue. Start by examining how System.Net.Http.dll version 4.2.0.0 is resolved from BuildExtensions and compare that with the working 0.24.1 or 0.42.1 behavior; done means the sample test can run and debug the referenced Target class without a FileNotFound error.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend, build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.