knative / knative/hack

Update `codegen-library.sh` to set exec flag on new k8s.io/code-generator scripts

Open
#335 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
26
Forks
70
PR merge metrics
No merged PRs in 30d

Description

As of `v0.28.0` of k8s.io/code-generator the `generate-groups.sh` script calls `generate-internal-groups.sh`. We should update our script to additionall add the exec flag for the `generate-internal-groups.sh` file.

https://github.com/kubernetes/code-generator/blob/791c213a776b4b92f9af0805c1cf57c118ba951c/generate-groups.sh#L66

Contributor guide

Open the contributing guide

Research direction

Start in codegen-library.sh and compare its handling of generate-groups.sh with the linked Kubernetes code-generator change. Confirm how generate-groups.sh invokes generate-internal-groups.sh, update the script so the new file receives the executable flag, and verify the generation flow completes with the resulting script executable.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, shell
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.