An unset variable in path: puts the working directory on PATH
- Lingua principale
- TypeScript
- Stelle
- 13
- Fork
- 1
- Merge medio
- 3h 38m
- PR unite (30g)
- 3
Descrizione
An unset variable in a `path:` entry expands to an empty string, and an empty `PATH`
element means the current directory to POSIX. So this front matter:
```yaml
path:
- $TOOL_DIR
```
silently puts the working directory on `PATH` when `TOOL_DIR` is not set, instead of
contributing nothing.
That is the wrong failure. A test that names a directory it cannot resolve should get a
clear "command not found", not a lookup that quietly searches somewhere the author never
named — and in a sandboxed run the working directory contains fixtures, which is exactly
where a stray executable could sit.
## Proposal
Drop entries that expand to empty, rather than passing them through.
A test asserting that a bare `$VAR` does not put the working directory on `PATH` would pin
it: today that assertion fails.
## Related
jlevy/tryscript#54 asks for `requires:`, which addresses the same underlying problem from
the other side — knowing which binary a run actually resolved rather than trusting `PATH`
composition to have gone as intended.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Direzione di ricerca
Locate the code that expands path: entries and inspect how unset variables become PATH elements. Add the proposed test using a bare $VAR, then verify that an empty expansion is omitted and the working directory is not searched; the test should produce a clear command-not-found result.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- cli, testing-qa
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Attiva
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 75/100