[JENKINS-56180] unstahing always success even if stash failed

No matter if stash succed or not unstash always pass.

I want to stash file but I dont know if it exists. If file exists everything goes well my_jar is saved and I can unstash it. But... if file doesnt exists it goes to catch() section and I guess that unstash also should go to catch() section but it's not happening. Instead of it  unstash return success (without any files). It means that during stash section "my_jar" label is created and unstash recognize it as stashed file.

 

(NODE1){

    try {

stash includes: 'some_jar.jar', name: 'my_jar'

    }

    catch(e){

       println(e.toString())

    }

}

.

.

.

(NODE2){

     try {

unstash 'my_jar'

     } 

    catch (e) {

println(e.toString())

//DO SOMETING

}

---
Originally reported by tomkoz, imported from: unstahing always success even if stash failed

• status: Open
  
• priority: Major
  
• component(s): workflow-basic-steps-plugin
  
• resolution: Unresolved
  
• votes: 0
  
• watchers: 1
  
• imported: 20251215-220547
  

Raw content of original issue

No matter if stash succed or not unstash always pass.


I want to stash file but I dont know if it exists. If file exists everything goes well my_jar is saved and I can unstash it. But... if file doesnt exists it goes to catch() section and I guess that unstash also should go to catch() section but it's not happening. Instead of it  unstash return success (without any files). It means that during stash section "my_jar" label is created and unstash recognize it as stashed file.


 



(NODE1){

    try {

        stash includes: 'some_jar.jar', name: 'my_jar'

    }

    catch(e){

       println(e.toString())

    }

}

.

.

.

(NODE2){

     try {

        unstash 'my_jar'

     } 

    catch (e) {

        println(e.toString())

        //DO SOMETING

}

Non vengono indicati file sorgente né test. Inizia riproducendo l’esempio stash/unstash a due nodi con una some_jar.jar mancante, quindi individua l’implementazione e i test di stash e unstash in workflow-basic-steps-plugin. Il lavoro è completato quando il fallimento segnalato è coperto da un test e il comportamento risultante è verificato.

Scritto dal modello di indicizzazione a partire dal testo della issue.