jenkinsci / jenkinsci/java-client-api

Regression of pull request #73 : URL encoding method is invalid for non-standard job

Aperta
#416 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
913
Fork
466
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Java-client-api version : 0.4.0-SNAPSHOT
Jenkins Server Version : 2.150.2

Latest version without Guava can't get xml config of a job with a space in its name:

org.apache.http.client.HttpResponseException: status code: 404, reason phrase: Not Found

at com.offbytwo.jenkins.client.validator.HttpResponseValidator.validateResponse(HttpResponseValidator.java:11)
at com.offbytwo.jenkins.client.JenkinsHttpClient.get(JenkinsHttpClient.java:170)
at com.offbytwo.jenkins.JenkinsServer.getJobXml(JenkinsServer.java:524)

Just looked at the code and since 0.4.0-SNAPSHOT with guava removal, a regression of pull request #73 occurs : job names with a space in them now contains the symbol "+" again, but there is an explicit comment in the latest code asking for the opposite
`// jenkins doesn't like the + for space, use %20 instead`

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.