jenkinsci / jenkinsci/java-client-api

Regression of pull request #73 : URL encoding method is invalid for non-standard job

Open
#416 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
913
Forks
466
PR merge metrics
No merged PRs in 30d

Description

Java-client-api version : 0.4.0-SNAPSHOT
Jenkins Server Version : 2.150.2

Latest version without Guava can't get xml config of a job with a space in its name:

org.apache.http.client.HttpResponseException: status code: 404, reason phrase: Not Found

at com.offbytwo.jenkins.client.validator.HttpResponseValidator.validateResponse(HttpResponseValidator.java:11)
at com.offbytwo.jenkins.client.JenkinsHttpClient.get(JenkinsHttpClient.java:170)
at com.offbytwo.jenkins.JenkinsServer.getJobXml(JenkinsServer.java:524)

Just looked at the code and since 0.4.0-SNAPSHOT with guava removal, a regression of pull request #73 occurs : job names with a space in them now contains the symbol "+" again, but there is an explicit comment in the latest code asking for the opposite
`// jenkins doesn't like the + for space, use %20 instead`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.