jamulussoftware / jamulussoftware/jamulus

Update the C-like style check to an ARM-compatible clang-format version

未关闭
#3,955 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@ann0see 已经在做这个了。

开始于 2026年9月15日。

refactoring
主要语言
C
星标
1.1k
派生
248
平均合并
2 天 3 小时
30 天内合并 PR
9

描述

## Summary

Update the C-like coding-style check to use a newer `clang-format` version on the Ubuntu 24.04 ARM runner.

The current workflow configures `DoozyX/clang-format-lint-action` with `clangFormatVersion: 14`. Version 14 was selected for Ubuntu 22.04 LTS. The job now uses `ubuntu-24.04-arm`.

## Rationale

The Docker action copies bundled `clang-format` executables into its image. The ARM runner cannot rely on a bundled executable unless that executable supports ARM64.

Ubuntu 24.04 provides an ARM64-native `clang-format-18` package. This is a newer supported version and is an ARM-compatible path for the workflow.

## Affected area

- `.github/workflows/coding-style-check.yml`
- `check-c-like-style` job

## Required changes

Replace or adapt the formatter invocation so that the ARM job installs and uses the Ubuntu 24.04 ARM64 `clang-format-18` package. Do not depend on an architecture-specific formatter binary from the current action unless ARM64 support is verified.

Review and apply any formatting changes that version 18 requires.

## Acceptance criteria

- The C-like style job runs successfully on `ubuntu-24.04-arm`.
- The job uses `clang-format` version 18 or another explicitly verified newer ARM64-compatible version.
- The job checks `.cpp`, `.h`, and `.mm` files with the existing repository style configuration.
- Required formatting updates are included or tracked before the version change is enabled.

## Research

Ubuntu's package index lists `clang-format-18` for Ubuntu 24.04 (`noble`) on `arm64`.

- https://packages.ubuntu.com/clang-format
- https://launchpad.net/ubuntu/noble/arm64/clang-format/1:18.0-59~exp2

## Backlinks

- Requested by @ann0see in https://github.com/jamulussoftware/jamulus/pull/3954#issuecomment-5679589906
- Related PR: https://github.com/jamulussoftware/jamulus/pull/3954

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。