jamulussoftware / jamulussoftware/jamulus
setRecordingDirectory replies "acknowledged" while silently disabling recording on a bad path
- Lingua principale
- C
- Stelle
- 1.1k
- Fork
- 248
- Merge medio
- 2g 3h
- PR unite (30g)
- 9
Descrizione
**🤖 AI:** `jamulusserver/setRecordingDirectory` always replies `"acknowledged"`, but a bad path silently disables recording and discards the stored directory — with nothing to roll back to, and if a recording was already running, it ends the WAV mid-session while the jam continues, unannounced.
**Root cause, confirmed on current `main` (`4a43f6f6`).** [`SetRecordingDir`](https://github.com/jamulussoftware/jamulus/blob/4a43f6f6bd49a37b79817a64450346724cba5752/src/recorder/jamcontroller.cpp#L98-L186) tears down the existing recorder thread ([`EndRecorderThread()` + `wait()`](https://github.com/jamulussoftware/jamulus/blob/4a43f6f6bd49a37b79817a64450346724cba5752/src/recorder/jamcontroller.cpp#L106-L107)) before validating the new directory; on failure [`strRecordingDir` is wiped to `""`](https://github.com/jamulussoftware/jamulus/blob/4a43f6f6bd49a37b79817a64450346724cba5752/src/recorder/jamcontroller.cpp#L184). [The RPC handler](https://github.com/jamulussoftware/jamulus/blob/4a43f6f6bd49a37b79817a64450346724cba5752/src/serverrpc.cpp#L342-L352) reports `"acknowledged"` regardless of which branch ran.
**Measured on a headless build (`wt-3861`, 2026-08-12; the cited lines read identical on current `main`).** A parent-is-a-file path and a path beyond `PATH_MAX` both flip `enabled`/`initialised` `True → False` and `recordingDirectory` → `""`, RPC still `"acknowledged"`.
**A recording already in flight stops at the instant the bad call returns.** A growing WAV (950,272 → 975,916 bytes across a good call) sits flat at every checkpoint afterward, while `getClients` keeps reporting the same live connection throughout — the jam itself is untouched, so nobody in the room is told recording just ended.
The identical failure is loud in the GUI — [`GetRecorderErrMsg()`](https://github.com/jamulussoftware/jamulus/blob/4a43f6f6bd49a37b79817a64450346724cba5752/src/serverdlg.cpp#L611-L618) drives a `QMessageBox::warning` — and silent over RPC, which discards the same string. `getRecorderStatus`'s `errorMessage` does carry it, and the method's own doc comment says to re-check — a caller who does so can catch this — but nothing prompts the re-check, and "acknowledged" does not suggest a session recording just silently ended.
---
🤖 *This message was written by AI and reviewed by @mcfnord.*
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia con SetRecordingDir in src/recorder/jamcontroller.cpp e con l’handler setRecordingDirectory in src/serverrpc.cpp; confronta il loro percorso di errore con GetRecorderErrMsg() in src/serverdlg.cpp e getRecorderStatus. Riproduci un percorso non valido e una registrazione in corso, quindi stabilisci la risposta di errore RPC prevista e il comportamento dello stato del registratore prima di identificare la copertura per entrambi i casi.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- cpp
- Ambito
- api, audio-video-rtc
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Attiva
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 48/100