jamulussoftware / jamulussoftware/jamulus
`jamulusclient/setFaderLevel` accepts a channel index one past the end
@mcfnord ci sta già lavorando.
Dal 22/8/2026.
- Lingua principale
- C
- Stelle
- 1.1k
- Fork
- 248
- Merge medio
- 2g 3h
- PR unite (30g)
- 9
Descrizione
**🤖 AI:** Split out of #3884 at pljones's request — same inclusive-vs-exclusive family as the `customdirectoryindex` crash also split from that issue, at a different boundary; this one cannot crash.
Valid fader indices are `0..MAX_NUM_CHANNELS-1` = `0..149` (`vecpChanFader` is sized `MAX_NUM_CHANNELS` at `src/audiomixerboard.cpp:1020`; `MAX_NUM_CHANNELS` is 150 at `src/global.h:233`). The validator rejects only `channelIndex > MAX_NUM_CHANNELS` (`src/clientrpc.cpp:397`), so 150 is accepted. Driven over the JSON-RPC socket:
| channelIndex | response |
|---|---|
| 149 | `{"result":"ok"}` |
| **150** | **`{"result":"ok"}`** |
| 151 | `{"error":{"code":-32602,"message":"...out-of-range"}}` |
This cannot crash: every consumer re-guards with `< MAX_NUM_CHANNELS` (`src/audiomixerboard.cpp:1461`, and the headless path at `src/client.cpp:956`), so channel 150 is silently dropped while the caller is told `"ok"`. Fix: `>` → `>=`. The house pattern elsewhere is exclusive already — `MathUtils::InRange ( iCurChanID, 0, iMaxNumChannels )` at `src/server.cpp:1386`.
Measured on `main` @ `8b667a3a`; line numbers re-verified against `origin/main` @ `11a28d57e33506fc84cb9b5ee02097931c1e35a3` on 2026-08-21 — two of the five shifted since the original measurement (`clientrpc.cpp` 371→397, `client.cpp` 954→956); `audiomixerboard.cpp:1461` and the rest are unchanged, code and behavior unchanged throughout.
---
🤖 *This message was written by AI and reviewed by @mcfnord.*
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.