jamulussoftware / jamulussoftware/jamulus

Index of measured findings not yet filed as issues

Ouverte
#3,916 17 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@mcfnord y travaille déjà.

Depuis le 22/8/2026.

Langage dominant
C
Étoiles
1.1k
Forks
248
Merge moyen
2 j 3 h
PR mergées (30 j)
9

Description

🤖 AI: An index of measured findings and candidate improvements against Jamulus that were not yet filed as issues, kept current so maintainers can pull whichever ones are worth a proper write-up. Nothing here needs a reply beyond "yes, open an issue for N" (or "no, not interested"). Each line is one command away from a standalone issue with the evidence, harness, and reproduce steps behind it. Status as of 2026-09-11, checked against main at 292506eb.

None of this is a new PR, it is a menu. If one of these turns into code later, it goes through the usual contribution process.

Filed since this index was posted (2026-08-21)
  • #3923 auto jitter buffer hysteresis compares against a constant (split out of this thread, open)
  • #3924 adaptive OPUS_SET_PACKET_LOSS_PERC (Discussion, open)
  • #3934 directory re-registration resolves DNS on the mix thread (open)
  • #3937 setRecordingDirectory acknowledges a bad path while disabling recording (open)
  • #3942 MIDI pick-up mode's rapid-movement branch is unreachable (open)
  • #3945 fade-in gain computed once per channel pair instead of once per channel per frame (open)
  • Merged: #3931 out-of-range customdirectoryindex startup crash, #3932 bIsIdentified made atomic, #3943 setSkillLevel with null returns ok, #3861 JSON-RPC read-buffer and setWelcomeMessage bounds.
JSON-RPC
Auto jitter buffer (all in corrados's #545 territory)
  • The hysteresis term has never functioned since it was added in 2011. Filed as #3923. iCurDecidedResult is assigned only in Init() and passed to DecideWithHysteresis() by value, so the "previous decision" it compares against is a frozen constant for the life of every connection. None of the three candidate behaviours (leave it frozen, delete it, or write the decision back) is free, and they differ in both latency and how often the size moves, so this is a design question rather than a cleanup.
  • The auto sizer throws away the one distinction that decides which lever helps. Not filed. It collapses every failure into a single scalar error rate, so it cannot tell late-but-complete arrivals (where more depth helps) from independent loss (where depth is wasted). A cheap run-length signal already computable inside CNetBuf::Get separates the two regimes cleanly in recorded traces. This is a design conversation, not a patch.
Server performance
  • The --multithreading pool-size default may be wrong. Not filed; still hoffie's own unanswered checkbox on #2446. On bare metal at realistic client counts, NUM_CORES-1 beats the shipped idealThreadCount(); and idealThreadCount() ignores CPU affinity on Qt5, so taskset does not resize the pool. The rule inverts on two-core hosts, so a naive idealThreadCount()-1 would regress them; any change has to floor or stay configurable.
  • The mixer inner loop has meaningful headroom. Two pieces are now in flight, the rewrite itself is not filed. The per-pair GetGain/GetPan locking is ann0see's ann0see/jamulus#293 (draft), completed by ann0see/jamulus#320; the per-pair fade-in read is #3945. The remaining candidate is a loop-interchange/vectorization rewrite that measured bit-identical to current output. It only matters on a busy (tens-of-clients) server and does nothing for a small jam, and it is the largest restructuring in the mix path, so it needs a design nod before any code.
Codec
  • The hardcoded OPUS_SET_PACKET_LOSS_PERC(35) is a fixed point on a tradeoff that is measured on both sides. Now Discussion #3924. It costs clean-line quality but buys real robustness under loss and jitter; both halves are quantified across the shipped quality tiers. A loss-adaptive value is the code-change candidate, but whether the clean-line cost is worth trading is a maintainer call.
Already-open issues re-verified with a root cause
  • #1591 (scrollbar resets on mute toggle) is still live on current main, localized to lblGlobalInfoLabel show/hide reflowing the mixer's QScrollArea. Milestone 4.1.0; pljones's note above stands: verify on all platforms and under Qt 6 before a fix.
  • #3604 (dedup the client/server "check for update" code) and #2438 (setChannelName written in two places with divergent truncation) both have small, verified refactor scopes ready to implement. Both open, milestone 4.1.0.

If any of these are worth pursuing, name it and a focused issue with the full evidence follows. Pointers to overlapping open issues or PRs are welcome.


🤖 This message was written by AI and reviewed by @mcfnord.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.