jamulussoftware / jamulussoftware/jamulus
Mac: Try re-enabling CodeQL on non-legacy build again
@hoffie ci sta già lavorando.
Dal 19/10/2022.
- Lingua principale
- C
- Stelle
- 1.1k
- Fork
- 248
- Merge medio
- 2g 3h
- PR unite (30g)
- 9
Descrizione
**What is the current behaviour and why should it be changed?**
In #2564 we've moved the CodeQL logic to the legacy build target. The reason was that enabling CodeQL got the build stuck during release signing. The legacy build is not signed, therefore, the problem didn't appear there.
I'm suspecting that it might be the same cause as #2925. In other words: It might just be that CodeQL builds are slower (they are!) and therefore hit the keychain re-lock timeout, which can be worked around.
**Describe possible approaches**
When #2925 is fixed, we could just re-enable CodeQL for the main build (and disable for legacy).
**Has this feature been discussed and generally agreed?**
No, but if it works, it should be good to go as it was a workaround only.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Valutazione
Questa issue non è ancora stata valutata.