Distinguish between datetime.datetime objects with a timezone and those without
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- 説明が足りない
- 活発さ
- 停滞
- 技術スタック
- python
調査の方向性
まず、提案されている型 DatetimeWithTimezone と DatetimeWithoutTimezone、および列挙されている datetime のコンストラクターとメソッドを確認してください。この区別を Python typing に互換性を保ったまま追加できるか、またそれが datetime ライブラリに属するものかを判断してください。完了には、これらの設計上の問題を解決し、合意されたスコープを定義する必要があります。
索引モデルが issue の本文から書いたものです。
説明
datetime.datetime objects created with timezone information cannot be compared to datetime objects without timezone information. This error comes up
TypeError: can't compare offset-naive and offset-aware datetimes
I believe it is possible for the type system to handle distinguishing between these two objects.
I have a proof of concept at my Company that looks something like this. The idea is to distinguish between these two object types and forbid their corresponding comparisons.
class DatetimeWithTimezone(datetime_lib.datetime):
"""Datetime with timezone."""
@overload
def replace(
self,
year: SupportsIndex = ...,
month: SupportsIndex = ...,
day: SupportsIndex = ...,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: _TzInfo = ...,
*,
fold: int = ...,
) -> Self: ...
@overload
def replace(
self,
year: SupportsIndex = ...,
month: SupportsIndex = ...,
day: SupportsIndex = ...,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: None = ...,
*,
fold: int = ...,
) -> DatetimeWithoutTimezone: ...
@overload
def astimezone(self, tz: _TzInfo) -> Self: ...
@overload
def astimezone(self, tz: None) -> DatetimeWithoutTimezone: ...
def utcoffset(self) -> timedelta: ...
def tzname(self) -> str: ...
def dst(self) -> timedelta: ...
def __le__(self, value: DatetimeWithTimezone, /) -> bool: ... # type: ignore[override]
def __lt__(self, value: DatetimeWithTimezone, /) -> bool: ... # type: ignore[override]
def __ge__(self, value: DatetimeWithTimezone, /) -> bool: ... # type: ignore[override]
def __gt__(self, value: DatetimeWithTimezone, /) -> bool: ... # type: ignore[override]
@overload # type: ignore[override]
def __sub__(self, value: Self, /) -> timedelta: ...
@overload
def __sub__(self, value: timedelta, /) -> Self: ...
class DatetimeWithoutTimezone(datetime_lib.datetime):
"""Datetime without timezone."""
@overload
def replace(
self,
year: SupportsIndex = ...,
month: SupportsIndex = ...,
day: SupportsIndex = ...,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: _TzInfo = ...,
*,
fold: int = ...,
) -> DatetimeWithTimezone: ...
@overload
def replace(
self,
year: SupportsIndex = ...,
month: SupportsIndex = ...,
day: SupportsIndex = ...,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: None = ...,
*,
fold: int = ...,
) -> Self: ...
@overload
def astimezone(self, tz: _TzInfo) -> DatetimeWithoutTimezone: ...
@overload
def astimezone(self, tz: None) -> Self: ...
def utcoffset(self) -> None: ...
def tzname(self) -> None: ...
def dst(self) -> None: ...
def __le__(self, value: DatetimeWithoutTimezone, /) -> bool: ... # type: ignore[override]
def __lt__(self, value: DatetimeWithoutTimezone, /) -> bool: ... # type: ignore[override]
def __ge__(self, value: DatetimeWithoutTimezone, /) -> bool: ... # type: ignore[override]
def __gt__(self, value: DatetimeWithoutTimezone, /) -> bool: ... # type: ignore[override]
@overload # type: ignore[override]
def __sub__(self, value: Self, /) -> timedelta: ...
@overload
def __sub__(self, value: timedelta, /) -> Self: ...
class datetime(datetime_lib.datetime):
@overload
def __new__(
cls,
year: SupportsIndex,
month: SupportsIndex,
day: SupportsIndex,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: _TzInfo = ...,
*,
fold: int = ...,
) -> DatetimeWithTimezone: ...
@overload
def __new__(
cls,
year: SupportsIndex,
month: SupportsIndex,
day: SupportsIndex,
hour: SupportsIndex = ...,
minute: SupportsIndex = ...,
second: SupportsIndex = ...,
microsecond: SupportsIndex = ...,
tzinfo: None = ...,
*,
fold: int = ...,
) -> DatetimeWithoutTimezone: ...
# On <3.12, the name of the first parameter in the pure-Python implementation
# didn't match the name in the C implementation,
# meaning it is only *safe* to pass it as a keyword argument on 3.12+
# Assume are on 3.12+
@overload
@classmethod
def fromtimestamp(
cls, timestamp: float, tz: None = ...
) -> DatetimeWithoutTimezone: ...
@overload
@classmethod
def fromtimestamp(
cls, timestamp: float, tz: _TzInfo
) -> DatetimeWithTimezone: ...
@overload
@classmethod
def now(cls, tz: _TzInfo) -> DatetimeWithTimezone: ...
@overload
@classmethod
def now(cls, tz: None = ...) -> DatetimeWithoutTimezone: ...
@overload
@classmethod
def combine(
cls, date: _Date, time: _Time, tzinfo: None = ...
) -> DatetimeWithoutTimezone: ...
@overload
@classmethod
def combine(
cls, date: _Date, time: _Time, tzinfo: _TzInfo
) -> DatetimeWithTimezone: ...
@classmethod
def strptime(
cls, date_string: str, format: str, /
) -> DatetimeWithTimezone | DatetimeWithoutTimezone: ...
I have some questions before I'm certain this could be possible for everyone
- Is it possible to make this backwards compatible?
- Is this something others are interested in?
- Should this actually be solved in the datetime library directly?
- 主要言語
- Python
- スター
- 1.8k
- フォーク
- 302
- 平均マージ
- 23時間
- マージ済み PR(30日)
- 8
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
python/typing のほかの issue
-
topic: typing spec
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
-
topic: typing spec
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
-
topic: documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
-
topic: documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
topic: conformance tests topic: typing spec
難易度 3/5 1〜2日 初心者へのやさしさ 72/100
似ている issue
-
link-check link-check:sphinx-theme
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
qgis/QGIS-Documentation#11275 ·
-
bug priority:normal ready-for-dev
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
OpenHands/extensions#626 · コメント 1 件 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
CSCfi/sd-search-api#39 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100