Add object shape inference to TypeScript mode (already in JSDoc+JavaScript mode)

オープン
#57,306 コメント 3 件 リアクション 3 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
javascript, typescript
領域
compilers

調査の方向性

まず、//@ts-check または checkJs の下で示されている JavaScript の動作を、対応する .ts の例と比較します。{} の後に代入されるプロパティを TypeScript がどのように推論すべきか、またオプションの tsconfig フラグでそれをどのように制御するかを判断します。TypeScript モードが要求されたオブジェクト形状の推論を、出力される JavaScript を変更せずにサポートすれば完了です。

索引モデルが issue の本文から書いたものです。

説明

Awaiting More Feedback Suggestion
🔍 Search Terms

object inference through property assignment

✅ Viability Checklist
⭐ Suggestion

So, whilst adding in JSDoc + //@ts-check to an existing project, I came across a type-inference feature that as far as I know, only exists in type-checked JavaScript.

In JavaScript, you can write a function like this:

// somefile.js
export function makeObject() {
  const foo = {};
  foo.a = 1;
  foo.b = '2';
  return foo;
}

However, what astonished me is that this type inference does not break when you add // @ts-check to the file. foo is properly typed based on assignment, and no error is thrown.

The Feature Request - Add this existing feature to .ts files (via a tsconfig flag)

// somefile.ts
export function makeObject() {
  const foo = {};
  foo.a = 1;
  foo.b = '2';
  return foo; // has a final shape of { a: number, b: string }, the same as JS does
}

TypeScript documentation, of course, says you can never do this, that object types cannot be inferred from assignment, and must instead either be typed up-front or, when inferred, inferred only by defining all the properties in the object. However, I've found there are lots of times when you want to infer an object's shape via assignment of the initial (function) scope (which is what is already supported in TS-checked JavaScript.

📃 Motivating Example

Mostly this would improve DX. I've had a number of situations where working JavaScript code had to be re-written the "TypeScript way" in order to get type inference. In many cases, migrating from JS to TS is a matter of adding types. However, in the case of objects, most legacy code "builds up" objects through assignment.

So, say you have this simple example, similar to something I've encountered often in legacy codebases:

export function makeObject() {
  const foo = {};
  foo.a = 1;
  foo.b = '2';
  return foo;
}

Now, immediately TypeScript will error at foo.a, because it says Property 'a' does not exist on type '{}'

Okay, so next the new TypeScript developer says, "alright, I'll add types to this object".

export function makeObject() {
  const foo: { a: number, b: string } = {};
  foo.a = 1;
  foo.b = '2';
  return foo;
}

This is, of course, wrong again. TypeScript says: Type '{}' is missing the following properties from type '{ a: number; b: string; }': a, b

But the developer is going to add them! In this case, if you don't want to massively refactor, you're left with a few bad options.

export function makeObject() {
  const foo = {} as { a: number, b: string };
  foo.a = 1;
  foo.b = '2';
  return foo;
}

This satisfies the types but it teaches a new TS developer to lean on as. Some teams will disallow / strongly discourage as as part of their linting settings because of the danger it implies.

Another option is this:

export function makeObject() {
  const foo: { a?: number, b?: string } = {};
  foo.a = 1;
  foo.b = '2';
  return foo as Required<typeof foo>;
}

Once again, we're leaning on string type assertion and using as.

The Obvious Question

Okay, so a seasoned / opinionated TS developer would say, "Why not just add a & b to the object definition"? Yes, in this very simple case, that's not much refactoring, but in codebases I've worked with, simply moving all the individual property assignments to the initial object declaration is a massive amount of refactoring. But even more importantly, IMO, better questions are:

  1. Should migrating to TypeScript force massive refactoring if the inference capabilities are already there?
  2. Is TypeScript "JavaScript + types"? Or is it a different language with specifically-omitted JavaScript patterns? Ideally, IMO, whatever types we can infer in a .js file with JS patterns, we should be able to infer in a .ts file with TS patterns.

(Of course, maybe this feature already exists in TypeScript with some TSConfig pattern that I couldn't find?)

💻 Use Cases
  1. What do you want to use this for?
    Every legacy code base I encounter.

  2. What shortcomings exist with current approaches?
    Blunt-force type-assertions or massive refactoring

  3. What workarounds are you using in the meantime?
    Both of the options from #2 OR simply using JSDoc + // @ts-check or "checkJs": true. I'm finding that in many cases, migrating from JS to TS is just too painful and time-consuming for some codebases because of object / constructor handling alone.

主要言語
Go
スター
111k
フォーク
14.4k
平均マージ
1日 19時間
マージ済み PR(30日)
117

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

microsoft/TypeScript のほかの issue

microsoft/TypeScript の issue をすべて見る

似ている issue

Go の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。