ApplicationIntegrationToolset silently builds no tools when a Connectors schema operation fails, and waits forever on one that never finishes
@sanketpatil06 がすでに取り組んでいます。
2026年9月18日 から。
評価
この issue はまだ評価されていません。
説明
🔴 Required Information
Describe the Bug:
ConnectionsClient._poll_operation() (used by ApplicationIntegrationToolset for connection entities and actions) has two problems:
- A failed operation is treated as success. A finished Connectors long-running operation carries either
responseorerror(google.longrunning.Operation). The loop only checksdone, and the callers then readresponse.jsonSchema/response.operations, falling back to{}/[]. So when the lookup fails, for example because of a mistyped entity or action name or a missing permission on the connection, the toolset builds without error and with no tools for that entity. With explicit operations it builds tools against an empty schema, and a failed action produces a tool with an empty display name. Nothing tells the developer why the agent can't reach the connector. - The wait is unbounded.
while not operation_done:has no deadline, so an operation that never finishes blocks toolset construction, and therefore agent startup, forever. bf4143ac bounded each HTTP call in this client for exactly this reason ("an unavailable endpoint could block agent execution indefinitely"), but the polling loop around those calls is still open-ended.
It also sleeps one extra second after the operation is already done, which slows every entity and action lookup.
Steps to Reproduce:
pip install google-adk(reproduced onmain@ f33d4923 / 2.9.0).- Run the script below. It builds a real
ApplicationIntegrationToolsetfor a connection whosegetEntityTypeoperation finishes witherror(entityAcountdoes not exist). HTTP is stubbed, so no GCP project is needed.
Expected Behavior:
Toolset construction fails with the operation's error message, and a stuck operation fails after a bounded wait.
Observed Behavior:
toolset built; tools: []
elapsed: 1.0s
Environment Details:
- ADK Library Version (pip show google-adk): 2.9.0 (
main@ f33d4923) - Desktop OS: Windows 11
- Python Version (python -V): 3.12.10
Model Information:
- Are you using LiteLLM: No
- Which model is being used: N/A (toolset construction, no model call)
🟡 Optional Information
Minimal Reproduction Code:
import asyncio
from unittest import mock
from google.adk.tools.application_integration_tool import ApplicationIntegrationToolset
from google.adk.tools.application_integration_tool.clients.connections_client import ConnectionsClient
FAILED_OP = {
"name": "operations/op-1",
"done": True,
"error": {"code": 5, "message": "Entity type 'Acount' not found."},
}
def fake_get(url, headers=None, timeout=None):
resp = mock.MagicMock(status_code=200)
if url.endswith("?view=BASIC"):
resp.json.return_value = {"name": "projects/p/locations/us-central1/connections/sfdc",
"serviceDirectory": "sd", "host": ""}
elif "getEntityType" in url:
resp.json.return_value = {"name": "operations/op-1"}
else:
resp.json.return_value = FAILED_OP
return resp
mod = "google.adk.tools.application_integration_tool.clients.connections_client"
with mock.patch(f"{mod}._mtls_utils.get_api_endpoint", return_value="connectors.googleapis.com"), \
mock.patch.object(ConnectionsClient, "_get_access_token", return_value="token"), \
mock.patch(f"{mod}.requests.get", side_effect=fake_get):
toolset = ApplicationIntegrationToolset(
project="p", location="us-central1", connection="sfdc",
entity_operations={"Acount": []}, # typo for "Account"
)
print("toolset built; tools:", [t.name for t in asyncio.run(toolset.get_tools())])
Suggested fix: in _poll_operation, raise ValueError with the operation's error message when a finished operation carries error. That's the error type the callers already document. Stop polling after a deadline with TimeoutError, and don't sleep once done is set. I have a PR ready with tests.
How often has this issue occurred?:
- Always (100%): any failed entity or action schema lookup.
- 主要言語
- Python
- スター
- 21.6k
- フォーク
- 4k
- 平均マージ
- 13時間 49分
- マージ済み PR(30日)
- 10
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
google/adk-python のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
google/adk-python#7217 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
google/adk-python#7206 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
google/adk-python#7205 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
google/adk-python#7196 · コメント 1 件 ·
-
eval request clarification
難易度 1/5 1〜3時間 初心者へのやさしさ 86/100
google/adk-python#7146 · コメント 2 件 · 担当者 1 名 ·
google/adk-python の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
zostera/django-bootstrap4#894 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
use-agent-os/agent-os#3276 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
zephyrproject-rtos/zephyr#119726 ·
-
area/auth bug comp/agent P3 platform/discord type/security
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
NousResearch/hermes-agent#117848 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
zilliztech/memsearch#759 ·