Enable developers to inject non-bolt arguments to listener function args
@seratch ci sta già lavorando.
Dal 25/8/2022.
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
I'm using dependency_injector to provide automatic dependency injection for my application, and I'm encountering an issue with Bolt overriding injected parameters with None since it doesn't recognize them.
Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`
The slack_bolt version
slack-bolt==1.14.3
slack-sdk==3.18.1
Python runtime version
Python 3.10.6
OS info
ProductName: macOS
ProductVersion: 12.5.1
BuildVersion: 21G83
Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., setup.py))
- Have a kwarg that is populated by some mechanism other than bolt (such as another decorator), e.g.
@app.command('/ping')
@inject
async def handle_ping(ack, respond, version: str = Provide[Container.config.VERSION]):
await ack()
await respond({
"blocks": [
SectionBlock(text=MarkdownTextObject(text='Pong!')),
DividerBlock(),
ContextBlock(elements=[
MarkdownTextObject(text=f'*Host:* {platform.node()}'),
MarkdownTextObject(text=f'*Version:* {version}')
])
]
})
Expected result:
Bolt doesn't touch the version kwarg, but still injects the ack and respond kwargs.
Actual result:
version ends up being set to None and Bolt logs the following warning: version is not a valid argument.
This is caused by this line.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
- Lingua principale
- Python
- Stelle
- 1.3k
- Fork
- 288
- Merge medio
- 1g 8h
- PR unite (30g)
- 10
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di slackapi/bolt-python
-
docs enhancement server-side
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
slackapi/bolt-python#1576 · 1 commento ·
-
auto-triage-skip bug security semver:major
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
slackapi/bolt-python#1447 · 9 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 65/100
slackapi/bolt-python#1577 ·
-
area:async auto-triage-skip dependencies
Difficoltà 3/5 1-2 giorni Idoneità per principianti 65/100
slackapi/bolt-python#1472 · 1 commento · 1 reazione ·
-
auto-triage-skip enhancement
slackapi/bolt-python#1346 · 2 commenti · 1 assegnatario ·