Compatibility Issue Due to Documentation/Configuration Mismatch

Aperta
#30 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
javascript, react, typescript
Ambito
build-system

Direzione di ricerca

Compare the installation instructions with the package's tsup configuration and the two package imports shown in the report. Reproduce the TypeScript error using the provided configuration, then verify that the documented dependency and configuration reference the same package and that the error is resolved.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Hello,

I am encountering a compatibility issue after following your package's installation instructions. The documentation indicates that a specific package should be installed; however, the tsup configuration appears to be referencing an older, incompatible version. This discrepancy is causing conflicts and preventing the package from functioning correctly.

Reproduction Steps

  1. Installed the package as instructed:

    yarn add esbuild-plugin-react18
    
  2. Configured tsup I think it use your old package esbuild-react18-useclient as follows:

    // tsup.config.ts or tsup.config.js
    import { defineConfig } from "tsup";
    import react18Plugin from "esbuild-react18-useclient";
    
    const react18PluginOptions: React18PluginOptions = {}
    export default defineConfig(options => ({
        ...
        esbuildPlugins:[react18Plugin(react18PluginOptions)]
    }));
    
  3. Attempted to use the following configuration, but encountered a TypeScript error:

    import { defineConfig } from 'tsup'
    import react18Plugin, { React18PluginOptions } from 'esbuild-plugin-react18'
    
    const react18PluginOptions: React18PluginOptions = {}
    export default defineConfig({
      entry: ['src/index.ts'],
      format: ['cjs', 'esm'],
      splitting: false,
      sourcemap: true,
      dts: true,
      minify: true,
      treeshake: true,
      external: ['react', 'react-dom'],
      esbuildPlugins: [react18Plugin(react18PluginOptions)],
    })
    

    TypeScript Error:

                Type '"external" | "bundle" | undefined' is not assignable to type '"external" | undefined'.
                  Type '"bundle"' is not assignable to type '"external"'.ts(2322)
    

Request

Could you please take a look at the tsup configuration within the package and ensure it aligns with the documented dependencies? I would greatly appreciate your assistance in resolving this matter.

Thank you for your time and consideration.

Lingua principale
TypeScript
Stelle
15
Fork
1
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react18-tools/esbuild-plugin-react18

Tutte le issue di react18-tools/esbuild-plugin-react18

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.