@types/react-native-vector-icons has dependency of deprecated @types/react-native

Aperta
#3,915 1 commento 2 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
react-native
Ambito
mobile, tooling

Direzione di ricerca

Start by inspecting the @rneui/base dependency metadata and the linked DefinitelyTyped types/react-native-vector-icons/package.json entry. Confirm which package introduces @types/react-native, then determine whether the dependency can be removed here or must be fixed upstream; done means installing @rneui/base no longer pulls in the deprecated package.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Needs Triage
Is there an existing issue for this?
  • I have searched the existing issues
Explain what you did

@rneui/base has a dependency of @types/react-native-vector-icons, but
@types/react-native-vector-icons has dependency of deprecated @types/react-native
relevant issue here
https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/70040

Expected behavior

@rneui/base should not depend on @types/react-native-vector-icons, only depend on react-native-vector-icons

Describe the bug

Not sure if this bug should be resolved in this repository, might be better to fix in here https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native-vector-icons/package.json#L10

@types/react-native is deprecated
https://www.npmjs.com/package/@types/react-native
should remove @types/react-native-vector-icons

Steps To Reproduce
just install @rneui/base in npm/yarn workspace
Screenshots

No response

Your Environment
`npx @rneui/envinfo`
    React Native Elements Env Info
   
    ## Global Dependencies:
   
      No related dependency found
   
   ## Local Dependencies:
   
    - @rneui/base : ^4.0.0-rc.7
    - @rneui/themed : ^4.0.0-rc.8
    - expo : ^51.0.20
    - react : 18.2.0
    - react-native : 0.74.3
    - @types/react : ~18.2.45
Lingua principale
MDX
Stelle
25.9k
Fork
4.7k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react-native-elements/react-native-elements

Tutte le issue di react-native-elements/react-native-elements

Issue simili

Altre issue su Mobile Dev

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.